Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Jan 29, 2025

PR-Codex overview

This PR focuses on updating the @thirdweb-dev/service-utils package, enhancing the rate limiting functionality by changing the parameter from project to team in the rateLimit function, and adding a new property billingPlanVersion to the TeamResponse.

Detailed summary

  • Updated version of @thirdweb-dev/service-utils from 0.7.2 to 0.7.3.
  • Added billingPlanVersion to TeamResponse.
  • Changed the rateLimit function to accept team instead of project.
  • Removed the updateRateLimitedAt function from the api.js.
  • Adjusted tests to reflect the new team parameter.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

jnsdls and others added 3 commits January 28, 2025 18:20
@jnsdls jnsdls requested a review from a team as a code owner January 29, 2025 19:31
@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: 8d18739

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:31pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:31pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:31pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:31pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 29, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@jnsdls jnsdls merged commit e8892b1 into main Jan 29, 2025
46 of 51 checks passed
@jnsdls jnsdls deleted the pass_team_instead_of_project_to_rateLimit branch January 29, 2025 19:32
@joaquim-verges joaquim-verges mentioned this pull request Jan 29, 2025
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.55 KB (0%) 932 ms (0%) 4 s (+23.94% 🔺) 5 s
thirdweb (cjs) 122.35 KB (0%) 2.5 s (0%) 7 s (-11.16% 🔽) 9.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 721 ms (+26.64% 🔺) 832 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 191 ms (+142.49% 🔺) 201 ms
thirdweb/react (minimal + tree-shaking) 19.27 KB (0%) 386 ms (0%) 558 ms (-46.07% 🔽) 944 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants